LFXV2-872: Tie chart releases to app releases by emsearcy · Pull Request #23 · linuxfoundation/lfx-v2-auth-service

emsearcy · 2026-02-04T00:20:22Z

This PR implements the standardized changes for LFXV2-872 to tie chart releases to app releases.

Changes Made

Chart.yaml Updates

Reset version from 0.3.4 to 0.0.1
Added explanatory comment about dynamic version replacement during chart build
Maintained appVersion: "latest" (already correct)

GitHub Workflow Updates

Updated CHART_VERSION calculation to use github.ref_name instead of reading from Chart.yaml
Updated helm-chart-oci-publisher to newer version @17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8

Testing

The changes ensure that:

Chart version is dynamically set to match the release tag during builds
Chart builds use the updated publisher with latest features
Version consistency between application and chart releases

Reset Chart.yaml version to 0.0.1 with explanatory comment. Update workflow to derive CHART_VERSION from git tag instead of Chart.yaml. Update helm-chart-oci-publisher to newer version @17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8. 🤖 Generated with [GitHub Copilot](https://github.com/features/copilot) (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>

coderabbitai · 2026-02-04T00:20:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b36480d and f0922df.

📒 Files selected for processing (1)

.github/workflows/ko-build-tag.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ko-build-tag.yaml

Walkthrough

This pull request changes Helm chart versioning to a static placeholder (0.0.1) with a note that CI will replace it, and updates the GitHub Actions workflow to derive the chart version from the Git ref and to use a different commit reference for the chart-publish action.

Changes

Cohort / File(s)	Summary
Helm Chart Configuration `charts/lfx-v2-auth-service/Chart.yaml`	Chart `version` changed from `0.3.4` to `0.0.1`; comments added stating the version is a placeholder and will be replaced during the chart build job.
CI/CD Workflow `.github/workflows/ko-build-tag.yaml`	CHART_VERSION assignment switched from parsing `charts/*/Chart.yaml` with `yq` to deriving from the GitHub ref name (stripping leading `v`); the Publish Chart to GHCR action reference was updated to a different commit hash.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly summarizes the main change: tying chart releases to app releases by modifying version handling and workflow logic.
Description check	✅ Passed	The description is comprehensive and clearly relates to the changeset, detailing all modifications to Chart.yaml and GitHub workflows with context and rationale.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch LFXV2-872-tie-chart-releases-to-app-releases

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR implements standardized changes to tie Helm chart releases directly to application releases by making the chart version dynamically match the git tag version instead of being manually maintained.

Changes:

Reset Chart.yaml version from 0.3.4 to 0.0.1 with explanatory comments about dynamic replacement during build
Modified workflow to derive CHART_VERSION from the git tag (github.ref_name) instead of reading from Chart.yaml
Updated helm-chart-oci-publisher action to a newer commit version

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
charts/lfx-v2-auth-service/Chart.yaml	Reset version to 0.0.1 and added comments explaining that the version is dynamically replaced during chart builds
.github/workflows/ko-build-tag.yaml	Changed CHART_VERSION calculation to use github.ref_name and updated helm-chart-oci-publisher to newer version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T00:22:00Z

charts/lfx-v2-auth-service/Chart.yaml

+# This version should not be incremented, as it is dynamically replaced with the release version during the chart build
+# job.
+version: 0.0.1


The README.md documentation is now outdated and contradicts these changes. Lines 153-154 and 190-191 instruct users to manually update the chart version in Chart.yaml before releases, but this PR changes the approach so that the chart version is now dynamically set to match the release tag. The documentation should be updated to reflect this new workflow where the chart version should not be manually incremented.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/ko-build-tag.yaml (1)
35-39: ⚠️ Potential issue | 🟡 Minor

Use anchored sed pattern to remove only the leading "v" from version tags.

The current sed 's/v//g' removes all "v" characters globally. While standard semantic versioning (v1.2.3, v1.2.3-alpha, etc.) avoids embedded "v" in identifiers, using sed 's/^v//' is more precise and defensive, removing only the leading "v".
🛠️ Suggested change
-          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')
           CHART_NAME="$(yq '.name' charts/*/Chart.yaml)"
-          CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')

…ervice into LFXV2-872-tie-chart-releases-to-app-releases

emsearcy requested a review from a team as a code owner February 4, 2026 00:20

Copilot AI review requested due to automatic review settings February 4, 2026 00:20

Copilot started reviewing on behalf of emsearcy February 4, 2026 00:20 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

coderabbitai bot reviewed Feb 4, 2026

View reviewed changes

andrest50 previously approved these changes Feb 4, 2026

View reviewed changes

Merge branch 'main' of ssh://github.com/linuxfoundation/lfx-v2-auth-s…

f0922df

…ervice into LFXV2-872-tie-chart-releases-to-app-releases

andrest50 dismissed their stale review via f0922df February 23, 2026 18:06

andrest50 approved these changes Mar 2, 2026

View reviewed changes

andrest50 merged commit 9374f25 into main Mar 2, 2026
6 checks passed

andrest50 deleted the LFXV2-872-tie-chart-releases-to-app-releases branch March 2, 2026 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LFXV2-872: Tie chart releases to app releases#23

LFXV2-872: Tie chart releases to app releases#23
andrest50 merged 2 commits intomainfrom
LFXV2-872-tie-chart-releases-to-app-releases

emsearcy commented Feb 4, 2026

Uh oh!

coderabbitai bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

emsearcy commented Feb 4, 2026

Changes Made

Chart.yaml Updates

GitHub Workflow Updates

Related

Testing

Uh oh!

coderabbitai bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Feb 4, 2026 •

edited

Loading